When I change a member's Role, their Read visibility isn't reflected correctly

(Bug, Closed -> Fixed, Priority: Critical, Test Status: Unit tested , Reported By Justin du Coeur, )
Security
Summary: This is in the new Space-evolution code; this bug should not make it into the live system.
  • Create a Space, with an Owner and Member.
  • Create a Model and an Instance.
  • Mark the Model and Instances as readable by Owner only. Confirm that Member can't see them.
  • Create a Role.
  • Change the Model and Instances to Custom Security, with Read assigned to the new Role. The Member still can't see them.
  • Assign the Role to the Member. They should be able to see Model and Instances, but can't until the Space is reloaded.
The problem is clearly in Space evolution: the change to the Role is probably being picked up by the evolution code, but it isn't recomputing the visibility accordingly.
For now, we should just do a full re-filter in this situation. We can then leave this bug open but low-priority, to be Much Much Cleverer in dealing with this scenario eventually.