Text Sets not displaying all members?
Summary: Some of my Text Sets are now only displaying their first member.
Check out Baron Blade - Terralunar Impulsion Beam Inventor. His Card Effects and Villain Setup are each showing only the first entry of the set. If you edit it, you can see that there is still data for two elements in each of those sets, but only the first is being displayed when not editing.
A long chain of events led to the current state, so there may be multiple bugs here, or weird edge-case interactions. I'll try and reconstruct the history in detail.
- I created these properties as Sets of Plain Text and entered in data.
- I noticed that the data had been split up into multiple entries at every comma within the text (the bug I originally intended to report).
- While looking into that, I noticed that the Properties were still Plain Text, when they should have just been Text, so I changed them to Text.
- After changing them to Text, Only the first entry of each set was displayed (and with an asterisk instead of a proper bullet).
- I manually rejoined the split-at-commas sub-entries into their proper chunks.
Justin (initial reactions): I should note that I don't think I've tested Sets of Text in the slightest yet. "Set" was invented for Tags/Links, and I really haven't done much with it outside of that. So I'm not totally astonished there are bugs.
Do you actually want Set here? Note that Sets, by definition, are unordered, and are supposed to display in sorted order. That seems unlikely to be ideal for your use case. I suspect you want List instead, since that has a controlled order. The Editor is preserving the order you entered the values in, but that's an implementation detail: the difference between List and Set is mainly that the former preserves order and the latter doesn't.
The comma-separation thing is by design, at least of the Manifest tool that we're using for Tag Sets. I'm a little surprised that it happened for Text Sets, but like I said, untested. (I am looking for opinions about whether to preserve comma separation for this. The theory in Manifest, I believe, is that you should be able to cut a text list of comma-separated values, and poof they become separate tags. I don't know if we actually want that in Querki, though.)
Later: I take that back. The comma-separation thing here is totally weird, because this shouldn't be one of the controls that does that. I don't have a clear recipe yet for when it happens (it's being inconsistent for me), and I'd love to get one.
Anyway -- all that said, your problem of only showing the first value trivially repros, even without the rest of the recipe, so it's clearly a real bug. And while Set of Text isn't intended as a common type, it ought to work sensibly, so I'll look into it.
Alexx: I probably do want List there, yeah. Will look into changing it soon.
